Modifying Image Template

Modifying Image Template

anqxyr 13 Dec 2015 19:40

We have a handful of images on the site that aren't using the standard image block component, because their current formatting cannot be recreated by it. Ideally, I want to get rid of all of them by adding optional arguments to the current component, or creating alternative components where arguments aren't enough.

As the first step I want to add an optional "link" argument to the standard image block template, that would allow for optional clickable images.

+proposed code changes

Image Block Base:

[[div class="scp-image-block" style="width:{$width};"]]
[[image {$name} style="width:{$width};" link={$link}]]
[[div class="scp-image-caption" style="width:{$width};"]]
{$caption}
[[/div]]
[[/div]]

Standard Image Block:

[[include component:image-block-base name={$name}|caption={$caption}|width={$width}|width=300px|link={$link}|link=#]]

Similar changes will be applied to the left-aligned image blocks.

So, thoughts?

EDIT: Here's some test pages:

http://scpsandbox2.wikidot.com/component-test-base
http://scpsandbox2.wikidot.com/component-test-block
http://scpsandbox2.wikidot.com/component-test-page

Last edited on 13 Dec 2015 19:55 by anqxyr Show more

Re: Modifying Image Template

Drewbear 13 Dec 2015 19:50

I'm not averse to this, but what about SCPs that use coding to cycle images, like the Psychiatric Tool polaroid one? Will we keep their current coding?

---

Giving bearhugs to the unsuspecting since 1872.

Re: Modifying Image Template

LurkD 13 Dec 2015 19:53

I imagine that this process will be a case-by-case basis and be applied only where it makes sense to do so.

Re: Modifying Image Template

anqxyr 13 Dec 2015 19:58

All cycling images that I know of (there are 2? 3?) rely on embeded off-site code. Wikidot doesn't have any way to cycle images that doesn't suck massively. As such, any changes to the templates shouldn't affect the cycling images in any way.

Re: Modifying Image Template

LurkD 13 Dec 2015 20:10

These changes look good and are in fact something that members, including myself, have been playing with for a while now. This is a good thing to implement, and I imagine the integration would be rather seamless after looking at this coding. Minimal cleanup I'd think.

Good job, anqxyr.

Re: Modifying Image Template

thedeadlymoose 14 Dec 2015 02:06

If the technical team supports this, then I support it.

Re: Modifying Image Template

Crayne 14 Dec 2015 07:23

I'd have preferred to have seen this beforehand, simply as a matter of principle, but I have faith in anqxyr's abilities. So, approving as Captain.

Re: Modifying Image Template

anqxyr 14 Dec 2015 08:48

Implemented the changes. Everything fine for the most part, but there's a small bug. Relative links to images without file extension (.jpg, .png, .etc) cause the image to become clickable, with the link leading to itself.

As far as I can tell, those images were bugged before. We never noticed because the only thing the bug was causing is for wikidot to host the image twice in two different places. Or I dunno, maybe that's a feature. A weird, obscure, pointless and unhelpful feature. Can't tell with wikidot.

There's at most 116 of those images. I'll be going through them today and adding extension to each.

Last edited on 14 Dec 2015 08:49 by anqxyr Show more

Re: Modifying Image Template

anqxyr 14 Dec 2015 11:22

Actually, just tested, and extension-less images being clickable is completely unrelated to the recent change, or to the image template at all. I added another image here to demonstrate: http://scpsandbox2.wikidot.com/component-test-page

I've stopped fixing those images for now. I would still like to do so, because this is ass backwards, but I'd like to hear others' thoughts on this first. Since this is a long-time bug, some authors may have used it intentionally to create clickable images. I don't know if any actually did, though, and if they did, they can just use the new link parameter instead now.

I consider this update to the standard image block component fully successful now.

Re: Modifying Image Template

Decibelles 15 Dec 2015 07:12

So as I understand this, this is to fix all clickable images? Some pages do this intentionally, as far as I know (SCP-2126 comes immediately to mind). I don't know much about how the technical side of things would be dealt with, but you'd probably have to see which ones do clickable images and which ones do it on purpose (considering you know the number of skips with clickable images, I assume this wouldn't be an ordeal). So, yeah, this sounds good.

Re: Modifying Image Template

anqxyr 15 Dec 2015 07:20

To clarify: I'm only talking about images that are clickable because they don't have a file extension (e.g. SCP-408).

Some images are made clickable purposefully and explicitly, by including a "link" parameter to the image code (e.g. SCP-2126). For those I'll be updating their formatting to use the image block component, and keeping them clickable.

For images without a file extension, on the other hand, there is no way to tell if they were made clickable on purpose or by mistake. I'm proposing adding file extensions to all of them, thereby making them non-clickable. If the author wants them to be clickable, they can then do so explicitly with a "link" parameter.

Last edited on 15 Dec 2015 07:23 by anqxyr Show more

Re: Modifying Image Template

Crayne 15 Dec 2015 09:20

I'm proposing adding file extensions to all of them, thereby making them non-clickable. If the author wants them to be clickable, they can then do so explicitly with a "link" parameter.

Sounds like the best way to handle this. I would propose to notify authors when they're article's been updated in this way.

Last edited on 15 Dec 2015 09:23 by Crayne Show more

Re: Modifying Image Template

anqxyr 15 Dec 2015 15:24

Another minor change I want to do: replace the code for component:image-block-quoted-base with this:

> [[div class="scp-image-block" style="width:{$width}; margin-top: 1em;"]]
> [[image {$name} width="{$width}" link={$link}]]
> [[div class="scp-image-caption"]]
> {$caption}
> [[/div]]
> [[/div]]
> \

This is a purely cosmetic change, to give the quoted image some distance from the top of the quote box. To see the difference, compare those two pages:

http://www.scp-wiki.net/scp-1036
http://scpsandbox2.wikidot.com/quoted-block-test-page

It'll also add the new "link" parameter to the quoted images, but that's a non-issue.

Could I get some yeas/nays on this?

Last edited on 15 Dec 2015 17:01 by anqxyr Show more

Re: Modifying Image Template

rumetzen 15 Dec 2015 15:30

I see no issue with this, as long as how to do it is made clear to newbies and such somewhere easy to find.

---

read YONQ

Re: Modifying Image Template

djkaktus 15 Dec 2015 16:39

Yeah, I super support this change.

That really is a fine squirrel, though.

Re: Modifying Image Template

(account deleted) 15 Dec 2015 17:25

The image stuff is pretty good but mostly I'm jumping in to say that we should fursecute kaktus

Re: Modifying Image Template

LurkD 15 Dec 2015 16:58

Maybe just a teeny bit more margin. Otherwise good.

Re: Modifying Image Template

thedeadlymoose 16 Dec 2015 06:27

Looks good.

Re: Modifying Image Template

anqxyr 19 Dec 2015 08:38

More stuff I want to change.

Right now we have three image component: image-block, image-block-left, and image-block-quoted. The left is different from the right only in being left-aligned. The quoted image is always right-aligned.

I'm proposing deprecating image-block-left, and instead adding an optional 'align' parameter to image-block and image-block quoted. The parameter would take 3 possible values: right (default), left, and center.

This would be beneficial in 3 ways: we'll have one less image component to maintain; we'll be able to center-align images, which is something that people were either asking for, or attempting to do themselves, poorly; and we'll be able to align quoted images same as the normal ones.

Here's a demo page: http://scpsandbox2.wikidot.com/component-test-page

The old image-block-left component would remain on the site until I've edited every page that uses it to use the new parameter instead, after which time it'll be deleted.

Thoughts?

Re: Modifying Image Template

thedeadlymoose 19 Dec 2015 08:40

I also approve of this.

Re: Modifying Image Template

Crayne 19 Dec 2015 12:43

Go for it. :)

Re: Modifying Image Template

anqxyr 23 Dec 2015 17:23

This is probably the last image issue I have that needs discussing.

Currently, 8 pages on the site are using a version of the old formatting that can't be replicated with the new components. These pages are

• http://www.scp-wiki.net/scp-1351
• http://www.scp-wiki.net/scp-2558-j
• http://www.scp-wiki.net/scp-006-j
• http://www.scp-wiki.net/scp-059
• http://www.scp-wiki.net/scp-1147
• http://www.scp-wiki.net/scp-1187
• http://www.scp-wiki.net/scp-1887
• http://www.scp-wiki.net/scp-676

You can see the formatting I'm talking about in any of them. It's a double-stacked image block, in which the lower image is connected to the caption of the upper images.

There are two possibilities here:

1. Create a new image component that would replicate this formatting.
2. Replace each double-stacked image block with two separate standard image components.

I'm strongly in favor of the option #2, for several reasons:

• A replacement component would be awkward to use, necessitating syntax like "name1=|caption1=|link1=|name2=|caption2=|link2="
• Visually, there isn't really that much difference between the current version and two separate consecutive images.
• I don't think that 8 pages is enough to warrant maintaining a separate image component.

Can get others' opinions on this?

Re: Modifying Image Template

TroyL 23 Dec 2015 18:36

Can you give a before and after of what #2 would look like? Feel free to use SCP-006-J for your test. I'm interested in seeing if it actually damages the appearance, but I think that it'll be fine.

---

"WELL FOUNDATION. YOU MADE IT SO EASY. SO VERY VERY EASY." - dimensionpotato

Re: Modifying Image Template

anqxyr 23 Dec 2015 19:03

http://imgur.com/MMG4k8j

Re: Modifying Image Template

TroyL 23 Dec 2015 20:49

This looks completely fine.

Edit, to clarify: I say go ahead and do it.

---

"WELL FOUNDATION. YOU MADE IT SO EASY. SO VERY VERY EASY." - dimensionpotato

Last edited on 23 Dec 2015 20:50 by TroyL Show more

Re: Modifying Image Template

Crayne 24 Dec 2015 12:37

Looks good to me too, go for it.

Re: Modifying Image Template

anqxyr 25 Dec 2015 16:22

All updates of the image formatting in individual pages have been finished. There may be some I have missed in a collapsible or somewhere, but there shouldn't be more than a handful of them, and I'll fix them one-by-one in undetermined future as I become aware of them.

Some numbers to finish this thing off:

SCP Articles:

Standard Image Components: 2277 images (1744 pages)
Other Image Formatting: 164 images (56 pages)

Tales:

Standard Image Components: 121 images (64 pages)
Other Image Formatting: 623 images (103 pages)